Jeff King <peff@xxxxxxxx> writes: > I don't think doing it this way is _wrong_. It just feels sort of > pointlessly over-engineered. It's also a little weird that all of the: > > if (advice_foo) > > will trigger because "advice_foo" is set to -1. I think it does the > right thing, but it feels like a bug (the value is now a tri-state, and > we silently collapse two states into one). Guilty as charged. I do agree that this is over-engineered. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html