On Mon, Aug 15, 2016 at 11:40:21AM -0700, Stefan Beller wrote: > When a user asked for a detached HEAD specifically with `--detach`, > we do not need to give advice on what a detached HEAD state entails as > we can assume they know what they're getting into as they asked for it. > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > --- > > Junio writes: > > It might be controversial how the second from the last case should > > behave, though. > > I agree. I think if the advice is configured explicitly we can still give it. > That makes the code a bit more complicated though. So....I guess. But has anybody in the history of git ever explicitly configured advice.* to true? It has never produced any change of behavior, and the whole point of "advice.*" was that git would advise by default, and you would use advice.* to shut it up once you were sufficiently educated. I don't think doing it this way is _wrong_. It just feels sort of pointlessly over-engineered. It's also a little weird that all of the: if (advice_foo) will trigger because "advice_foo" is set to -1. I think it does the right thing, but it feels like a bug (the value is now a tri-state, and we silently collapse two states into one). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html