Re: [PATCH] refs.c: add a function to sort a ref list, rather then sorting on add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Apr 2007, Linus Torvalds wrote:



On Tue, 17 Apr 2007, Julian Phillips wrote:

It's the tag auto-following code, I'm calling read_ref to see if I already
have that tag - and it appears that doing that a few thousand times takes a
while.

Heh. I think we should probably call read_refs() just once to read them
all (when most of them are packed, that's cheap), and then after that,
have some way to just check for a match on the refs we have cached.

I had a look at the exclude_existing function in show-ref. That uses for_each_ref to build a path_list, and path_list_has_path to do the filtering...

Using that I get (worst of 5, warm cache):
real    0m0.526s
user    0m0.302s
sys     0m0.176s

--
Julian

 ---
The descent to Hades is the same from every place.
		-- Anaxagoras
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]