Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > On Tue, 17 Apr 2007, Julian Phillips wrote: >> >> Rather than sorting the refs list while building it, sort in one go >> after it is built using a merge sort. This has a large performance >> boost with large numbers of refs. >> >> Signed-off-by: Julian Phillips <julian@xxxxxxxxxxxxxxxxx> > > Acked-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > > Looks fine. I think that even your new times are a bit high (over two > seconds?) but things are clearly better. Have you looked at what takes so > long now? I wonder why the loss of "we are replacing the same one" case in the original add_ref() was not compensated for in the new sort_ref_list(). I think we would not call add_ref() to the same list with duplicate names, unless (1) filesystem is grossly corrupt, (2) somebody added a new ref while we are walking (how does readdir() behave in such a case???), or (3) packed-refs file is corrupt. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html