Re: [PATCH] display the subject of the commit just made

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Quoting Junio C Hamano <junkio@xxxxxxx>:
> Subject: Re: [PATCH] display the subject of the commit just made
> 
> "Michael S. Tsirkin" <mst@xxxxxxxxxxxxxxxxxx> writes:
> 
> > Display the subject of the commit just made.
> >
> > Useful e.g. to figure out what I did from screen history,
> > or to make sure subject line is short enough and makes sense
> > on its own.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxxxxxxxxxx>
> >
> > ---
> >
> >> Quoting Junio C Hamano <junkio@xxxxxxx>:
> >> Close but no cigar.  You broke it for a merge commit, I think.
> >> 
> >> Perhaps
> >> 
> >> 	pretty="format:Created${initial_commit:+ initial} commit %h: %s%n"
> >> 	git-diff-tree --always --shortstart --summary --root --pretty="$pretty" HEAD
> >
> > OK, thanks fo rpointing this out.
> > But why the extra %n at the end?
> 
> Because I *got* *rid* *of* "echo".

Oh.
But, this seems to stick an extra newline before the shortstart summary,
instead of at the end. No?

 ./git-commit.sh --amend
Created commit 63cfb8c: test more

 1 files changed, 1 insertions(+), 1 deletions(-)

while in my version

 ./git-commit.sh --amend
Created commit 63cfb8c: test more
 1 files changed, 1 insertions(+), 1 deletions(-)

so I think we are stuck with echo.


-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]