"Michael S. Tsirkin" <mst@xxxxxxxxxxxxxxxxxx> writes:
> BTW, a couple of questions:
> 1. do we really need the shortstat info?
I am between neutral to slightly negative, so I won't miss it if
it is removed, but I'll let people who wanted it to defend it.
> 2. why is there "--" at the end do in the original version?
Blame is always your friend.
$ git blame -L'/^git-diff-tree .*--$/,1' git-commit.sh
finds that it came from this commit:
commit 521f9c4def9430526bfdfffdb8ed4c2f4166bece
Author: Michael Loeffler <zvpunry@xxxxxxxxxx>
Date: Mon Jan 8 20:23:13 2007 +0100
git-commit: do not fail to print the diffstat even if there is a file named HEAD
Signed-off-by: Michael Loeffler <zvpunry@xxxxxxxxxx>
Signed-off-by: Junio C Hamano <junkio@xxxxxxx>
diff --git a/git-commit.sh b/git-commit.sh
index 04aad5e..c2beb76 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -628,7 +628,7 @@ then
if test -z "$quiet"
then
echo "Created${initial_commit:+ initial} commit $commit"
- git-diff-tree --shortstat --summary --root --no-commit-id HEAD
+ git-diff-tree --shortstat --summary --root --no-commit-id HEAD --
fi
fi
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html