Re: [PATCH v12 04/20] index-helper: new daemon for caching index and related stuff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 17, 2016 at 6:43 PM, Christian Couder
<christian.couder@xxxxxxxxx> wrote:
> On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote:
>> From: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
>>
>> +static void loop(int fd, int idle_in_seconds)
>> +{
>> +       assert(idle_in_seconds < INT_MAX / 1000);
>
> This assert may not be very nice to users setting the value using --exit-after.

Yeah. We could catch this after parsing --exit-after (and before
forking to background, losing stderr) for invalid values and forget
about this assert.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]