Re: [PATCH v12 03/20] pkt-line: add gentle version of packet_write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote:
> +int packet_flush_gently(int fd)
> +{
> +       packet_trace("0000", 4, 1);
> +       return write_in_full(fd, "0000", 4) != 4;
> +}

The return value convention here is a bit weird, isn't it? Usually we
have "zero good, minus one  (or negative) bad" or "zero bad, positive
good". This one goes "zero good, one bad". Same goes for the other
_gently() function.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]