Hey Junio, On Tue, Jun 14, 2016 at 3:40 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> It is easy to be misguided on the return value of the function >> strbuf_read_file(). It does follow the pattern of other standard functions >> for reading files but its better to explicitly specify it. > > Good thing to do; I wonder if we want to explicitly say -1 or > leave it at "negative values are errors", though (my knee-jerk > reaction being "do not over-specify more than absolute minimum > to write callers correctly"). Sure I will re-roll with specifying about negative values as errors. Regards, Pranit Bauva -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html