On Tue, Jun 14, 2016 at 12:32:15AM -0400, Eric Sunshine wrote:
> > + struct string_list range_list = STRING_LIST_INIT_NODUP;
>
> Related to this series, there's an additional "fix" which ought to be
> made, probably as a separate patch. In particular, in cmd_blame():
>
> if (lno && !range_list.nr)
> string_list_append(&range_list, xstrdup("1"));
>
> which supplies a default range ("line 1 through end of file") if -L
> was not specified. I used xstrdup() on the literal "1" in 58dbfa2
> (blame: accept multiple -L ranges, 2013-08-06) to be consistent with
> parse_opt_string_list() which was unconditionally xstrdup'ing the
> argument (but no longer does as of patch 1/3 of this series).
Yeah, I'd agree that this is a minor bug both before and after the
series due to the leak. Want to roll a patch on top?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html