On Fri, Jun 03, 2016 at 07:47:24AM +0000, Elia Pinto wrote:
> diff --git a/wrapper.c b/wrapper.c
> index 5dc4e15..0d44835 100644
> --- a/wrapper.c
> +++ b/wrapper.c
> @@ -433,16 +433,11 @@ int xmkstemp(char *template)
> int git_mkstemp(char *path, size_t len, const char *template)
> {
> const char *tmp;
> - size_t n;
>
> tmp = getenv("TMPDIR");
> if (!tmp)
> tmp = "/tmp";
> - n = snprintf(path, len, "%s/%s", tmp, template);
> - if (len <= n) {
> - errno = ENAMETOOLONG;
> - return -1;
> - }
> + (void)xsnprintf(path, len, "%s/%s", tmp, template);
> return mkstemp(path);
> }
I don't think this one is a good change. git_mkstemp is a library
function, and there are places that indirectly call it (via the gpg
code) that do not die when it fails (and even if all the callers _did_
die, isn't "could not create temporary file ..." a better error message
than "BUG: attempt to snprintf into too-small buffer"?).
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html