On Fri, Jun 03, 2016 at 04:49:18AM -0400, Jeff King wrote: > I haven't looked carefully at each call site in detail yet, but from the > previous rounds of sprintf handling, I'd guess each site falls into one > of two categories: So that being said, I did just look at several of them. And I think they _do_ fall into these categories, but I think the solutions don't necessarily. So what I would do is find solutions for each, and then go back and group them by situation and solution-type using "git rebase -i". It may be that you end up with 10 patches, or it may be that you see some patterns. But I think grouping is helpful for reviewers, because it communicates the patterns you found while doing the work. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html