On Wed, Jun 1, 2016 at 1:48 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > John Keeping <john@xxxxxxxxxxxxx> writes: > >> Absolutely, my original point should have been prefixed with: I wonder >> if the reason we haven't had any problems reported is because ... >> >> And we've got lucky because the clobbering of global variables happens >> not to matter in these particular cases. > > Ah, I did misunderstand why you were making that statement, and now > I fully agree with your conclusion (which is what Jeff spelled out > in the latest message) that the fact that we saw no breakage report > is not a datapoint that everybody's shell supports "local" at all. > > Thanks for clarification. I think both the use of submodules and the use of shells not supporting 'local' is a minority in our current user base, so I am not surprised that nobody complained about that, as the overlap between submodule users and non-local shell users may even be zero. The patch just sent, looks good to me for the minimal fix in the tests. Thanks, Stefan > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html