On Wed, Jun 01, 2016 at 07:31:00PM +0100, John Keeping wrote:
> > > reset_submodule_urls () {
> > > - local root
> > > - root=$(pwd) &&
> > > (
> > > + root=$(pwd) &&
> > > cd super-clone/submodule &&
> > > git config remote.origin.url "$root/submodule"
> > > ) &&
> > > (
> > > + root=$(pwd) &&
> > > cd super-clone/submodule/sub-submodule &&
> > > git config remote.origin.url "$root/submodule"
> [...]
> I wonder if it's relevant that the "local root" line isn't &&-chained?
> Is it possible that on some shells we ignore an error but everything
> still works?
I don't think so. We're inside a function, so we wouldn't affect any
outer &&-chaining in the function (and there isn't any in the caller
anyway). I think it's a reasonable custom not to bother &&-chaining
"local" lines, as they come at the top of a function and can't fail.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html