On 05/28/2016 05:04 PM, Matthieu Moy wrote:
Eric Wong <e@xxxxxxxxx> writes:
Samuel GROOT <samuel.groot@xxxxxxxxxxxxxxxx> wrote:
(mbox) Adding cc: A<author@xxxxxxxxxxx> from line 'Cc: A<author@xxxxxxxxxxx>, One<one@xxxxxxxxxxx>'
(mbox) Adding cc: One<one@xxxxxxxxxxx> from line 'Cc: A<author@xxxxxxxxxxx>, One<one@xxxxxxxxxxx>'
Though `git send-email` now outputs something like:
(mbox) Adding cc: A<author@xxxxxxxxxxx> from line 'Cc: A<author@xxxxxxxxxxx>'
(mbox) Adding cc: One<one@xxxxxxxxxxx> from line 'Cc: One<one@xxxxxxxxxxx>'
I actually like neither, and would prefer something shorter:
(mbox) Adding cc: A <author@xxxxxxxxxxx> from Cc: header
(mbox) Adding cc: One <one@xxxxxxxxxxx> from Cc: header
(mbox) Adding cc: SoB <SoB@xxxxxxxxxxx> from Signed-off-by: trailer
That way, there's no redundant addresses in each line and less
likely to wrap.
I agree with this. Actually, I'd even say that the current output of
"git send-email" looks sloppy, and internal refactoring may be a good
opportunity to get it cleaner.
I agree.
Should we take what Eric suggested (see below) as standard output?
Since the headers are already shown after those lines, it's
redundant to have the entire line. And we could add
trailers after the headers (with a blank line to delimit):
# existing header output:
From: F <F@xxxxxxxxxxx>
Cc: A <author@xxxxxxxxxxx>, One <one@xxxxxxxxxxx>
Subject: foo
# new trailer output
Signed-off-by: SoB <SoB@xxxxxxxxxxx>
Acked-by: ack <ack@xxxxxxxxxxx>
And keep "(mbox) Adding ..." lines as error output, or maybe displayable
by a new option `--verbose`?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html