Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Wong <e@xxxxxxxxx> writes:

> Samuel GROOT <samuel.groot@xxxxxxxxxxxxxxxx> wrote:
>
>>    (mbox) Adding cc: A<author@xxxxxxxxxxx>  from line 'Cc: A<author@xxxxxxxxxxx>, One<one@xxxxxxxxxxx>'
>>    (mbox) Adding cc: One<one@xxxxxxxxxxx>  from line 'Cc: A<author@xxxxxxxxxxx>, One<one@xxxxxxxxxxx>'
>> 
>> Though `git send-email` now outputs something like:
>> 
>>    (mbox) Adding cc: A<author@xxxxxxxxxxx>  from line 'Cc: A<author@xxxxxxxxxxx>'
>>    (mbox) Adding cc: One<one@xxxxxxxxxxx>  from line 'Cc: One<one@xxxxxxxxxxx>'
> I actually like neither, and would prefer something shorter:
>
>     (mbox) Adding cc: A <author@xxxxxxxxxxx> from Cc: header
>     (mbox) Adding cc: One <one@xxxxxxxxxxx> from Cc: header
>     (mbox) Adding cc: SoB <SoB@xxxxxxxxxxx> from Signed-off-by: trailer
>
> That way, there's no redundant addresses in each line and less
> likely to wrap.

I agree with this. Actually, I'd even say that the current output of
"git send-email" looks sloppy, and internal refactoring may be a good
opportunity to get it cleaner.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]