On Thu, May 26, 2016 at 10:29 PM, Jeff King <peff@xxxxxxxx> wrote: > On Thu, May 26, 2016 at 06:36:46PM +0530, Mehul Jain wrote: > The documentation here mentions "log" and "show". But I think this will > affect other programs, too, including "whatchanged" and "reflog". Those > ones are probably good, but the documentation is a little misleading (I > think other options just say "git-log and related commands" or > something). Yes, the documentation is misleading. As you have mentioned, this config variable will affect git-log, git-show, git-whatchanged and git-reflog. I will mention them in the documentation. >> diff --git a/t/t4202-log.sh b/t/t4202-log.sh >> index 128ba93..36be9a1 100755 >> --- a/t/t4202-log.sh >> +++ b/t/t4202-log.sh >> @@ -890,6 +890,25 @@ test_expect_success GPG 'log --graph --show-signature for merged tag' ' >> grep "^| | gpg: Good signature" actual >> ' >> >> +test_expect_success GPG 'log.showsignature=true behaves like --show-signature' ' >> + git checkout -b test_sign master && >> + echo foo >foo && >> + git add foo && >> + git commit -S -m signed_commit && >> + test_config log.showsignature true && >> + git log -1 signed >actual && >> + test_i18ngrep "gpg: Signature made" actual && >> + test_i18ngrep "gpg: Good signature" actual >> +' > > You can see in the context that we do not use test_i18ngrep for finding > gpg output in existing tests. I'm not sure if the new tests should be > consistent, or if they should be changed to use test_i18ngrep. I don't > think it's actually doing anything here, though. It's used with a > git-specific GETTEXT_POISON flag that tweaks the output generated by > git, but not by sub-programs like gpg. There was no real motivation behind usage of test_i18ngrep. Certainly, usage of grep will fit in the context. >> +test_expect_success GPG '--show-signature overrides log.showsignature=false' ' >> + test_when_finished "git reset --hard && git checkout master" && >> + git config log.showsignature false && > > Should this be test_config? Noted. Thanks, Mehul -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html