On Fri, May 13, 2016 at 02:23:25PM -0400, Jeff King wrote: > This covers all cases detected by: > > git grep 'test -z [^"]' > > (though note that has a few false positives for tests which > need an extra layer of quoting to do '\"'). I looked at those false positives, and they're really gratuitous uses of double-quotes that cause the extra layer of quoting. So I set off to fix that, but along the way found an actual bug (in the final patch here), along with a few minor readability fixups. [1/3]: t/lib-git-svn: drop $remote_git_svn and $git_svn_id [2/3]: t9100: enclose all test code in single-quotes [3/3]: t9107: use "return 1" instead of "exit 1" -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html