Jeff King <peff@xxxxxxxx> writes: > On Fri, May 13, 2016 at 02:49:53PM +0100, Adam Dinwoodie wrote: > >> (Tangentially: what's the accepted practice for submitting failing test >> scripts? I've written a short test case to add to t0020 that shows this >> bugged behaviour, but I've got the vague impression from past emails >> that leading with the patch email adding the failing test case is not >> the expected way to do things on this list...) > > We don't want commits that fail the test suite, since it makes bisection > more difficult. But you can mark known bugs like: > > test_expect_failure 'git-foo should output bar' ' > ... > ' > > I think it's OK to submit a patch like that. Hopefully somebody picks > that up and combines it with their fix patch, but if not, then it at > least documents the failure for later generations. ... but we do not want to overdo this. An expect_failure helps when somebody is actually starting to work on a breakage by setting a goal, but otherwise nobody would look at them. I do not think we know if 120+ instances of expect_failure in t/ we already have are still all valid; some of them even might be requesting a behaviour that we decided is a wrong expectation later. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html