Re: /* compiler workaround */ - what was the issue?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Stefan Beller" <sbeller@xxxxxxxxxx>
On Fri, May 6, 2016 at 12:57 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
Marc Branchaud <marcnarc@xxxxxxxxxxx> writes:

On 2016-05-06 02:54 PM, Junio C Hamano wrote:

I wonder if can we come up with a short and sweet notation to remind
futhre readers that this "initialization" is not initializing but
merely squelching warnings from stupid compilers, and agree to use
it consistently?

Perhaps

      #define COMPILER_UNINITIALIZED_WARNING_INITIALIZER 0

or, for short-and-sweet


          /* Here could go a longer explanation than the 4 character
define :) */
      #define CUWI 0

?

:)

I get that smiley.

I was hinting to keep the /* compiler workaround */ comment, but
in a bit shorter form.
--

For some background, I found $gmane/169098/focus=169104 which covers some of the issues (the focused msg is one from Junio). Hannes then notes ($gmane/169121) that the current xx = xx; could be seen as possible undefined behaviour - perhaps one of those 'no good solution' problems.

Perhaps a suitable name...

#define SUPPRESS_COMPILER_UNINITIALIZED_WARNING 0
/* Use when some in-use compiler is unable to determine if the variable is used uninitialized, and no good default value is available */

Though, where best to put it?

--
Philip
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]