On Thu, May 5, 2016 at 4:27 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >>> I wonder if the patches mentioned have something to do with the "git >>> add deep/in/the/tree" that fails to notice deep/in/ is an unrelated >>> repository in some way? >> >> Which is considered a feature now. Maybe we should add tests for that? >> >> http://debuggable.com/posts/git-fake-submodules:4b563ee4-f3cc-4061-967e-0e48cbdd56cb > > That is a bug, plain and simple. Duy any ideas where we went wrong? That was my first reaction as well. However after a while of thought I actually like that bug. Consider the possibilities how gitk/git-gui or other subsystems can be developed. When accepting a patch for that you can either apply the patch in the outer or inner repository, depending on what the sender used. I am not so sure if it is a bug plain and simple, but devolved into a "feature" now. > > I think we already have code to avoid adding beyond symlinks. > "git add deep/in/the/tree" should refuse if deep/in is a symbolic > link (and happens to point at a directory that has the/tree in it). > We used not to catch that long time ago, but I think we fixed it. > > The logic and the places to do the checks for "no, that thing may be > a directory but is an unrelated repository" should be the same. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html