On Thu, May 5, 2016 at 4:09 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> `check_path_for_gitlink` was introduced in 9d67b61f739a (2013-01-06, >> add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse) >> but the implementation was removed in 5a76aff1a6 (2013-07-14, add: >> convert to use parse_pathspec). >> >> Remove the declaration from the header as well. >> >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> >> --- >> pathspec.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/pathspec.h b/pathspec.h >> index 0c11262..b596aed 100644 >> --- a/pathspec.h >> +++ b/pathspec.h >> @@ -96,7 +96,6 @@ static inline int ps_strcmp(const struct pathspec_item *item, >> >> extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec); >> extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen); >> -extern const char *check_path_for_gitlink(const char *path); >> extern void die_if_path_beyond_symlink(const char *path, const char *prefix); >> >> #endif /* PATHSPEC_H */ > > Interesting. > > I wonder if the patches mentioned have something to do with the "git > add deep/in/the/tree" that fails to notice deep/in/ is an unrelated > repository in some way? Which is considered a feature now. Maybe we should add tests for that? http://debuggable.com/posts/git-fake-submodules:4b563ee4-f3cc-4061-967e-0e48cbdd56cb -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html