On Mon, May 2, 2016 at 11:02 AM, Jeff King <peff@xxxxxxxx> wrote: > On Mon, May 02, 2016 at 10:40:28AM -0700, Junio C Hamano wrote: > >> "Keller, Jacob E" <jacob.e.keller@xxxxxxxxx> writes: >> >> > True. I think the chances that it needs such a thing are quite minor, >> > and if an undocumented knob gets exposed it would have to become >> > documented and maintained, so I'd prefer to avoid it. Given that the >> > risk is pretty small I think that's ok. >> >> OK, then let's do only the "documentation" part. >> >> -- >8 -- >> Subject: [PATCH] diff: undocument the compaction heuristic knobs for experimentation >> >> It seems that people around here are all happy with the updated >> heuristics used to decide where the hunks are separated. Let's keep >> that as the default. Even though we do not expect too much trouble >> from the difference between the old and the new algorithms, just in >> case let's leave the implementation of the knobs to turn it off for >> emergencies. There is no longer need for documenting them, though. > > I agree with this reasoning. Thanks. > > -Peff I think I agree too. Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html