On Fri, Apr 29, 2016 at 1:29 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jeff King <peff@xxxxxxxx> writes: > >> ... Having the two directly next to each other reads >> better to me. This is a pretty unusual diff, though, in that it did >> change the surrounding whitespace (and if you look further in the diff, >> the identical change is made elsewhere _without_ touching the >> whitespace). So this is kind of an anomaly. And IMHO the weirdness here >> is outweighed by the vast number of improvements elsewhere. > > So... is everybody happy with the result and now we can drop the > tweaking knob added to help experimentation before merging the > result to 'master'? > > I am pretty happy with the end result myself. I am very happy with it. I haven't had any issues, and I think we'll find better traction by enabling it at this point and seeing when/if someone complains. I think for most it won't be noticed and for those that do it will likely be positive. Thanks, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html