On Tue, May 03, 2016 at 01:03:38AM -0400, Jeff King wrote: > On Sun, May 01, 2016 at 12:10:09PM +0200, Torsten Bögershausen wrote: > > > On 2016-05-01 08.02, Mike Hommey wrote: > > > get_port() is only used as a fallback when get_host_and_port() does not > > > return a port. But get_port() does the same search as > > > get_host_and_port(), except get_host_and_port() starts from the end of > > > the host, respecting square brackets for ipv6 addresses, and get_port(), > > > operating after get_host_and_port(), works on a modified host string > > > that has square brackes removed if there were any. > > typo: brackets. > > > > > > I cannot think of any legal host:port string that would not have a port > > > returned by get_host_and_port() *and* have one returned by get_port(). > > > So just remove get_port(). > > > > > > Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx> > > Does this pass the test-suite ? > > It doesn't pass here, t5601: > > Hmm. I do notice that Mike's patch only touches the ssh code path. The > normal TCP code path _just_ uses get_host_and_port. Does that mean the > TCP side is missing some cases, or is the extra parsing just for > handling bracketed "[host:port]:path" cases for ssh, like: > > > not ok 39 - bracketed hostnames are still ssh > > # > > # git clone "[myhost:123]:src" ssh-bracket-clone && > > # expect_ssh "-p 123" myhost src > > # > > ? The latter. Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html