On 2016-05-01 08.02, Mike Hommey wrote: > get_port() is only used as a fallback when get_host_and_port() does not > return a port. But get_port() does the same search as > get_host_and_port(), except get_host_and_port() starts from the end of > the host, respecting square brackets for ipv6 addresses, and get_port(), > operating after get_host_and_port(), works on a modified host string > that has square brackes removed if there were any. typo: brackets. > > I cannot think of any legal host:port string that would not have a port > returned by get_host_and_port() *and* have one returned by get_port(). > So just remove get_port(). > > Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx> Does this pass the test-suite ? It doesn't pass here, t5601: not ok 39 - bracketed hostnames are still ssh # # git clone "[myhost:123]:src" ssh-bracket-clone && # expect_ssh "-p 123" myhost src # not ok 40 - uplink is not treated as putty # # copy_ssh_wrapper_as "$TRASH_DIRECTORY/uplink" && # git clone "[myhost:123]:src" ssh-bracket-clone-uplink && # expect_ssh "-p 123" myhost src # not ok 41 - plink is treated specially (as putty) # # copy_ssh_wrapper_as "$TRASH_DIRECTORY/plink" && # git clone "[myhost:123]:src" ssh-bracket-clone-plink-0 && # expect_ssh "-P 123" myhost src # not ok 42 - plink.exe is treated specially (as putty) # # copy_ssh_wrapper_as "$TRASH_DIRECTORY/plink.exe" && # git clone "[myhost:123]:src" ssh-bracket-clone-plink-1 && # expect_ssh "-P 123" myhost src # not ok 43 - tortoiseplink is like putty, with extra arguments -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html