On Thu, Apr 28, 2016 at 8:56 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Thu, Apr 28, 2016 at 7:02 AM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: >> Hi Peff, >> >> On Thu, 28 Apr 2016, Jeff King wrote: >> >>> On Thu, Apr 28, 2016 at 08:17:53AM -0400, Jeff King wrote: >>> >>> > So that case _is_ correct right now. It's just that t5550 isn't testing >>> > the shell script part, which is broken. Probably running "git submodule >>> > update" in the resulting clone would cover that. >>> > >>> > And for the fetch case, we probably just need to be calling >>> > prepare_submodule_repo_env() there, too. >>> >>> So here's a series which fixes sanitizing in the "git-submodule" shell >>> script, along with "git fetch". And cleans up a few things along the >>> way. >> >> Nice! >> >> I reviewed those changes and they all look sensible to me (did not apply >> them locally for lack of time, though). > > Same here. > Same as well. Looks good, and good catch finding the bug! Thanks, Jake >> >> Ciao, >> Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html