Nicolas Pitre <nico@xxxxxxx> writes: > On Fri, 6 Apr 2007, Junio C Hamano wrote: > >> arjen@xxxxxxxx (Arjen Laarhoven) writes: >> >> > In the test 'compare delta flavors', /usr/bin/stat is used to get file size. >> > This isn't portable. There already is a dependency on Perl, use its '-s' >> > operator to get the file size. >> >> If you do use Perl, then you do not want to do it as two >> separate invocations with their result compared with test. >> >> How about this on top of your patch? > > Well... since this test already depends on wc then why not just use that > instead of adding a perl dependency? Because (1) other tests already use Perl; (2) wc -c reads pack to find out the size, "-s $file" doesn't AFAIK. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html