On Fri, 6 Apr 2007, Junio C Hamano wrote:
> arjen@xxxxxxxx (Arjen Laarhoven) writes:
>
> > In the test 'compare delta flavors', /usr/bin/stat is used to get file size.
> > This isn't portable. There already is a dependency on Perl, use its '-s'
> > operator to get the file size.
>
> If you do use Perl, then you do not want to do it as two
> separate invocations with their result compared with test.
>
> How about this on top of your patch?
Well... since this test already depends on wc then why not just use that
instead of adding a perl dependency?
Something like:
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 35e036a..ba785cf 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -125,8 +125,8 @@ cd "$TRASH"
test_expect_success \
'compare delta flavors' \
- 'size_2=`stat -c "%s" test-2-${packname_2}.pack` &&
- size_3=`stat -c "%s" test-3-${packname_3}.pack` &&
+ 'size_2=`wc -c < test-2-${packname_2}.pack` &&
+ size_3=`wc -c < test-3-${packname_3}.pack` &&
test $size_2 -gt $size_3'
rm -fr .git2
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html