On Mon, Apr 4, 2016 at 6:38 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Mon, Apr 4, 2016 at 4:07 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: >>>> Given that the ifndef/endif block immediately before this part is >>>> also about excluding -p/-u/--patch when formatting the documentation >>>> for format-patch, perhaps the attached may be a smaller equivalent? >>> >>> Perhaps. I kept self-contained to make it easier to add new options >>> between the two if need be, but I don't feel strongly about it. >> >> I don't either, but the reason why I thought it would make sense to >> have them in the same block is because hiding --no-patch and --patch >> are about the same theme: format-patch is about presenting the diff, >> and neither disabling diff output nor explicitly asking for diff >> output makes sense. > > That's reasonable. Should I re-roll, or would you like to amend it locally? Okay, I just pulled upon seeing "What's Cooking" and see that you amended it locally. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html