Nicolas Pitre <nico@xxxxxxx> writes: > Make it conditionnal on --stdin then. This covers all cases where we > really want the secure thing to happen, and the --stdin case already > perform the atomic rename-and-move thing when the pack is fully indexed. Repacking objects in a repository uses pack-objects without using index-pack, as you suggested Chris. Is there a sane usage of index-pack that does not use --stdin? I do not think of any. If there isn't, the "conditional on --stdin" suggestion means we unconditionally do the secure thing for all the sane usage, and go unsecure for an insane usage that we do not really care about. If so, it seems to me that it would be the simplest not to touch the code at all, except that missing free(). Am I missing something? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html