Re: [PATCHv19 00/11] Expose submodule parallelism to the user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 29.02.2016 um 22:19 schrieb Junio C Hamano:
Stefan Beller <sbeller@xxxxxxxxxx> writes:

Maybe we want to remove the struct child_process from the
function signature of the callbacks and callbacks need to rely on
the data provided solely thru the pointer as passed around for
callback purposes, which the user is free to use for any kind
of data.

I think that is the most sensible.

I also think that is the better approach. Dumping out the argv array is not the best end-user experience. It is just a debugging aid, and for that we have (or should extend if necessary) GIT_TRACE infrastructure. Moreover, a command that failed should have printed error messages, and it is not necessary to follow it up with another "A child process exited with code N" message.

-- Hannes

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]