On Thu, Feb 25, 2016 at 09:26:14PM -0500, Eric Sunshine wrote: > On Thu, Feb 25, 2016 at 9:19 PM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote: > > On Thu, Feb 25, 2016 at 5:55 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > >> Not worth a re-roll, but these quote sequences are brain-melting. > >> Easier would have been to double-quote the second argument of > >> test_expect_success() and then do either: > > > > They are. I fiddled with things till I got it working. I wasn't sure > > if double quotes would cause a problem or not, since most other tests > > seemed to avoid it. > > You normally want variable interpolations within the test to happen > when the test is actually run rather than when it is defined, which is > why single quotes are normally used. But this test doesn't use any > variable interpolations, so double quotes won't hurt it. Of the two you suggested, I think I like the here-doc better, as it does not leave any question to a reader that there is other interpolation going on. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html