Re: [PATCH v3 2/2] git: submodule honor -c credential.* from command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 25, 2016 at 5:55 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> Not worth a re-roll, but these quote sequences are brain-melting.
> Easier would have been to double-quote the second argument of
> test_expect_success() and then do either:
>

They are. I fiddled with things till I got it working. I wasn't sure
if double quotes would cause a problem or not, since most other tests
seemed to avoid it.

However this re-roll forgot to check argc in submodule--helper so
maybe worth reroll to fix both things?

Thanks
Jake
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]