On Mon, Feb 15, 2016 at 4:39 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> On Mon, Feb 15, 2016 at 03:34:51PM -0500, Jeff King wrote: >>> So I think this hack should remain purely at the curl level, and never >>> touch the credential struct at all. >>> >>> Which is a shame, because I think Eric's suggestion is otherwise much >>> more readable. :) >> >> Yes, I agree. That would have been a much nicer and smaller change. > > Alright, reading all reviews and taking them into account, the > original, when a Sign-off is added, would be acceptable, it seems. One final question: Keeping in mind my lack of familiarity with this particular use-case, would it be possible to infer the need to employ this curl-specific workaround rather than making users tweak a config setting? Or would that be a security risk or an otherwise stupid idea? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html