On Mon, Feb 15, 2016 at 01:39:30PM -0800, Junio C Hamano wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > > > On Mon, Feb 15, 2016 at 03:34:51PM -0500, Jeff King wrote: > > ... > >> So I think this hack should remain purely at the curl level, and never > >> touch the credential struct at all. > >> > >> Which is a shame, because I think Eric's suggestion is otherwise much > >> more readable. :) > > > > Yes, I agree. That would have been a much nicer and smaller change. > > Alright, reading all reviews and taking them into account, the > original, when a Sign-off is added, would be acceptable, it seems. Sorry about that. Please add my Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: PGP signature