Re: [PATCH 8/8] one ugly test to verify basic functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 5, 2016 at 6:57 PM, Elia Pinto <gitter.spiros@xxxxxxxxx> wrote:
>> +       mv `ls .git/objects/pack/*.pack` pack &&
>
> No, please. From the git coding guideline : "We prefer $( ... ) for
> command substitution; unlike ``, it properly nests.

I was being too subtle with the word "ugly". I assure you this test
cannot be merged in its current form.

But that's not important. It makes me think, can we catch `..`
automatically? I know the test suite can catch broken && command
sequence. Maybe we can do the same for`..`?

> It should have been the way Bourne spelled it from day one, but
> unfortunately isn't."
>
> http://stackoverflow.com/questions/4708549/whats-the-difference-between-command-and-command-in-shell-programming
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]