Hi John, On Thu, 4 Feb 2016, John Keeping wrote: > On Thu, Feb 04, 2016 at 02:13:47PM +0100, Johannes Schindelin wrote: > > Whatever the outcome, the inconsistency must be fixed. > > I disagree. Unless there are other changes in the same area, the noise > isn't worth it. > > However, I do think we need to agree on a policy so that new code can be > consistent. This should then be documented in CodingGuidelines. If you want to enforce it in the future, how can you possibly be against fixing the inconsistency in the existing code? Sorry, I am really unable to understand this. Also, we *did* document the policy in the CodingGuidelines: As for more concrete guidelines, just imitate the existing code So. There you are. By that token, my patch series was the correct thing to do because the first arithmetic expression introduced into a shell script in Git's source code had no spaces. At this point I am a bit fed up with the discussion because by now it feels to me more like a Slashdot thread than a technical discussion with a direction. As far as technical direction goes, here is the summary of what I have to say: I still think that the changes I submitted are good because they seem to me to reinstate the coding style with which we started out. And that's really all I have to say about this matter. Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html