Hi John, On Thu, 4 Feb 2016, John Keeping wrote: > Using spaces around operators also matches our C coding style. Well, by that reasoning you should go the whole nine yards and write lineno = $(( $lineno + 1 )) Except you can't. Because shell code is inherently not like C code. What I found particularly interesting about 180bad3 (rebase -i: respect core.commentchar, 2013-02-11) was that it *snuck in* that coding style: it *changed* the existing one (without rationale in the commit message, too). Ciao, Johannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html