Stefan Beller <sbeller@xxxxxxxxxx> writes: > This rewrites parse_config to distinguish between configs specific to > one submodule and configs which apply generically to all submodules. > We do not have generic submodule configs yet, but the next patch will > introduce "submodule.fetchJobs". OK. > +static int parse_config(const char *var, const char *value, void *data) > +{ > + struct parse_config_parameter *me = data; > + int subsection_len; > + const char *subsection, *key; > + > + if (parse_config_key(var, "submodule", &subsection, > + &subsection_len, &key) < 0) > + return 0; > + > + if (!subsection_len) > + return parse_generic_submodule_config(key, var, value, me); The same comment as in the footnote for the review on [3/8] applies here. > + else > + return parse_specific_submodule_config(subsection, > + subsection_len, key, > + var, value, me); > +} > + > static int gitmodule_sha1_from_commit(const unsigned char *commit_sha1, > unsigned char *gitmodules_sha1) > { -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html