Re: [PATCH v2 5/5] ls-remote: add support for showing symrefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 18, 2016 at 11:09:13PM +0100, Thomas Gummerer wrote:

> > +test_expect_failure 'ls-remote with filtered symrefs (--heads)' '
> > +	git symbolic-ref refs/heads/foo refs/tags/mark &&
> > +	cat >expect <<-\EOF &&
> > +	ref: refs/heads/bar	refs/tags/mark
> > +	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/foo
> > +	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/master
> > +	EOF
> > +	git ls-remote --symrefs --heads . >actual &&
> > +	test_cmp expect actual
> > +'
> 
> I'm a bit confused by this.  Shouldn't the "ref: refs/heads/bar
> refs/tags/mark" line only show up when we use --tags, not --heads?
> Also should refs/heads/bar be refs/heads/foo?

Yes, sorry, I bungled this. It should expect:

  ref: refs/tags/mark\trefs/heads/foo

I changed my mind about which refs to use halfway through writing, and
of course because it is marked to expect failure, running the test
didn't clue me in. :)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]