On Mon, Jan 18, 2016 at 4:21 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> On Jan 18, 2016 13:11, "Eric Sunshine" <sunshine@xxxxxxxxxxxxxx> wrote:
>> On Thu, Jan 14, 2016 at 3:45 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> If for some reason interpret-trailers fails to fail, this would
>>> leave an unreadable 'message' in the trash directory. Maybe no
>>> other tests that come after this one want to be able to read the
>>> contents of the file right now, but this is an accident waiting to
>>> happen:
>>>
>>> cat basic_message >message &&
>>> + test_when_finished "chmod +r message" &&
>>> chmod -r message &&
>>> test_must_fail ... &&
>>> chmod +r message &&
>>
>> Don't forget to remove this (now unnecessary) "chmod +r" once you've
>> added the 'test_when_finished "chmod +r"'.
>>
>>> test_cmp ...
>
> It still is necessary for the test-cmp to work, no?
My bad. Ignore me.
By the way, isn't the:
cat basic_message >message &&
in the above test just an unusual way to say:
cp basic_message message &&
?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html