Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Fri, Jan 15, 2016 at 9:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>>> It is somewhat hard to see how this avoids stripping one (or both) >>>> slashes just after "http:" in remoteurl="http://site/path/";, leaving >>>> just "http:/" (or "http:"). >>> >>> it would leave just 'http:/' if url were to be ../../some/where/else, >>> such that the constructed url below would be http://some/where/else. >> >> Is that a good outcome, though? Isn't it something we would want to >> catch as an error? > > I would want to add theses checks later and for now > just port over the code from shell to C. (The same issue > is found in the shell code and nobody seems to bother so far) Understood and I think that is a good direction to go. Perhaps leave a comment in the area to document it as a known bug (or a NEEDSWORK) to make it more obvious and to help remember it? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html