On 2016-01-13 at 20:20:04 +0100, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Tobias Klauser <tklauser@xxxxxxxxxx> writes: > > > Use fprintf instead of printf in trailer.c in order to allow printing > > to a file other than stdout. This will be needed to support in-place > > editing in git interpret-trailers. > > > > Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx> > > Thanks. I won't bother to amend it myself or request you to reroll > only for this, but that is a rather suboptimal title. Agree. > The distinction between fprintf/printf is an implementation detail; > what you want to do in this change is to allow writing to a file > other than the standard output, and that should be in the title. Since I'll do a v4 anyhow to address Eric's review comments, I can change the title in the reroll. Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html