Re: [PATCH v3 1/2] trailer: use fprintf instead of printf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tobias Klauser <tklauser@xxxxxxxxxx> writes:

> Use fprintf instead of printf in trailer.c in order to allow printing
> to a file other than stdout. This will be needed to support in-place
> editing in git interpret-trailers.
>
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>

Thanks.  I won't bother to amend it myself or request you to reroll
only for this, but that is a rather suboptimal title.

The distinction between fprintf/printf is an implementation detail;
what you want to do in this change is to allow writing to a file
other than the standard output, and that should be in the title.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]