Re: [PATCH] git-revert: Revert revert message to old behaviour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 24 Mar 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> 
> >> How about the empty line in between the message and the "This reverts 
> >> commit "..
> >> 
> >> > +		add_to_msg("Revert \"");
> >> >  		add_to_msg(oneline);
> >> > -		add_to_msg("\nThis reverts commit ");
> >> > +		add_to_msg("\"\nThis reverts commit ");
> >> 
> >> This should probably be
> >> 
> >> 	add_to_msg("\"\n\nThis reverts commit ");
> >> 
> >> with *two* \n's, no?
> >
> > Yes. Sorry.
> 
> Not only that.  
> 
> The older one had two, duplicated abbrev, and your fix reduces
> it to once, but we do not want any abbrev there.

D'oh.

Thanks,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]