Re: [PATCH] git-revert: Revert revert message to old behaviour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 23 Mar 2007, Linus Torvalds wrote:

> On Fri, 23 Mar 2007, Johannes Schindelin wrote:
> > 
> > When converting from the shell script, based on a misreading of the
> > sed invocation, the builtin included the abbreviated commit name,
> > and did _not_ include the quotes around the oneline message.
> > 
> > This fixes it.
> 
> How about the empty line in between the message and the "This reverts 
> commit "..
> 
> > +		add_to_msg("Revert \"");
> >  		add_to_msg(oneline);
> > -		add_to_msg("\nThis reverts commit ");
> > +		add_to_msg("\"\nThis reverts commit ");
> 
> This should probably be
> 
> 	add_to_msg("\"\n\nThis reverts commit ");
> 
> with *two* \n's, no?

Yes. Sorry.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]