On Thu, Dec 10, 2015 at 7:46 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Christian Couder <christian.couder@xxxxxxxxx> writes:
>
>>>> +/* Untracked cache mode */
>>>> +enum uc_mode {
>>>> + UNDEF_UC = -1,
>>>> + NO_UC = 0,
>>>> + UC,
>>>> + FORCE_UC
>>>> +};
>>>> +
>>>
>>> With these, the code is much easier to read than with the mystery
>>> constants, but did you consider making UC_ a common prefix for
>>> further ease-of-reading? E.g.
>>>
>>> UC_UNSPECIFIED
>>> UC_DONTUSE
>>> UC_USE
>>> UC_FORCE
>>>
>>> or something?
>>
>> Ok, I will use what you suggest.
>
> As you know I am bad at bikeshedding; the only suggestion in the
> above is to have common UC_ prefix ;-) Don't take what follow UC_
> as my suggestion.
I am bad at finding names too, so I think what you wrote is pretty good.
I thought about the following:
UC_UNDEF
UC_DISABLE
UC_ENABLE
UC_TEST
UC_FORCE
but I am not sure it is much better.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html