Christian Couder <christian.couder@xxxxxxxxx> writes:
>>> +/* Untracked cache mode */
>>> +enum uc_mode {
>>> + UNDEF_UC = -1,
>>> + NO_UC = 0,
>>> + UC,
>>> + FORCE_UC
>>> +};
>>> +
>>
>> With these, the code is much easier to read than with the mystery
>> constants, but did you consider making UC_ a common prefix for
>> further ease-of-reading? E.g.
>>
>> UC_UNSPECIFIED
>> UC_DONTUSE
>> UC_USE
>> UC_FORCE
>>
>> or something?
>
> Ok, I will use what you suggest.
As you know I am bad at bikeshedding; the only suggestion in the
above is to have common UC_ prefix ;-) Don't take what follow UC_
as my suggestion.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html