This is a proposed revision of David Turner's refs-backend-pre-vtable
v5 [1]. It incorporates all of the changes I suggested when reviewing
that series, plus it moves the refs-related code to a subdirectory and
creates a new header file refs/refs-internal.h for declarations meant
to be used within the refs module but not by other code. I've retained
the authors of the original patches because most of what I've done is
just shift things around and adjust some includes and comments
accordingly.
This branch proposes the following file layout for the refs module:
refs.h
refs/refs.c
refs/refs-internal.h
refs/files-backend.c
refs/lmdb-backend.c <- suggested name for the upcoming LMDB code
I changed the name of "refs-be-files.c" to "refs/files-backend.c"
because otherwise the "refs" would have been redundant with the
subdirectory name, and now there is room in the filename to spell out
"backend".
Summary of changes in my branch vs. your v5:
* Rename refs-be-files.c to refs/files-backend.c
* Rename refs.c to refs/refs.c
* Introduce a new header file, refs/refs-internal.h, to hold
declarations that are needed by other refs backends but shouldn't
be used by non-refs code. The end result is that refs.h is almost
unchanged by this series.
* Adjust commit messages for the new file locations.
* Instead of making verify_refname_available() public, move it to
refs/refs-internal.h. (I think this function will only be needed
by other refs backends and not by other code.) This change
required your patch 03/26 to be moved later in the series.
* Add a missing LF in your patch 18/26.
* Touch up the log message and comments in your patch 25/26.
* Drop patch 26/26, Peff's "introduce "extensions" form of
core.repositoryformatversion", as that patch is already in master.
These patches are also available as the `refs-backend-pre-vtable`
branch in my GitHub repo [2].
I don't want to hijack this patch series or anything, but it seemed
simpler to express my suggestions as code. Feel free to pick and
choose what you like and submit a v7 if that is your preference.
Michael
[1] http://thread.gmane.org/gmane.comp.version-control.git/280325
[2] https://github.com/mhagger/git
David Turner (9):
refs: make is_branch public
refs: move transaction functions to the common code
refs: move refname_is_safe to the common code
refs: move copy_msg to the common code
refs: move peel_object to the common code
refs: move should_autocreate_reflog to common code
initdb: make safe_create_dir public
files_log_ref_write: new function
refs: break out ref conflict checks
Ronnie Sahlberg (16):
refs/files-backend.c: new file, renamed from refs.c
refs: add a new file, refs/refs.c, to hold common refs code
refs: move update_ref to refs/refs.c
refs: move delete_pseudoref and delete_ref to the common code
refs: move read_ref_at to the common refs file
refs: move the hidden refs functions to the common code
refs: move dwim and friend functions to the common refs code
refs: move warn_if_dangling_symref* to the common code
refs: move read_ref, read_ref_full and ref_exists to the common code
refs: move resolve_refdup to common
refs: move check_refname_format to the common code
refs: move is_branch to the common code
refs: move prettify_refname to the common code
refs: move ref iterators to the common code
refs: move head_ref_namespaced to the common code
refs: create a shared version of verify_refname_available
Makefile | 5 +-
builtin/init-db.c | 12 -
cache.h | 8 +
path.c | 12 +
refs.h | 2 +
refs.c => refs/files-backend.c | 1291 ++--------------------------------------
refs/refs-internal.h | 200 +++++++
refs/refs.c | 1073 +++++++++++++++++++++++++++++++++
8 files changed, 1348 insertions(+), 1255 deletions(-)
rename refs.c => refs/files-backend.c (75%)
create mode 100644 refs/refs-internal.h
create mode 100644 refs/refs.c
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html